Add regression coverage for quoted dotted column aliases#23155
Open
kosiew wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@nuno-faria |
…table column-list aliasing fix(planner): remove redundant clone after plan.schema().columns()
kosiew
force-pushed
the
pr-22917-followup-01
branch
from
8a5d696 to
729231a
Compare
nuno-faria
approved these changes
Jun 24, 2026
nuno-faria
left a comment
nuno-faria
left a comment
Contributor
There was a problem hiding this comment.
Thanks @kosiew, LGTM.
Comment on lines
+108
to
+109
| # Test quoted dotted column names with subquery column-list aliasing | ||
| # (https://github.com/apache/datafusion/issues/22916) |
Contributor
There was a problem hiding this comment.
I think we should combine these new tests with the ones above, since some parts are repeated.
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
|
@nuno-faria |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow up to #22917, I overlooked these:
What changes are included in this PR?
This PR adds SLT regression coverage for quoted dotted column names used with table column-list aliasing, including qualified and unqualified references.
It also removes a redundant
.clone()call afterplan.schema().columns().Are these changes tested?
Yes. Tests are added in:
datafusion/sqllogictest/test_files/alias.sltAre there any user-facing changes?
No user-facing changes.
LLM-generated code disclosure
This PR includes LLM-generated code and comments. All LLM-generated content has been manually reviewed.