Test: add more aggregation focused dictionary sql logic test#23280
Open
Rich-T-kid wants to merge 1 commit into
Open
Test: add more aggregation focused dictionary sql logic test#23280Rich-T-kid wants to merge 1 commit into
Rich-T-kid wants to merge 1 commit into
Conversation
Contributor
Author
|
@Dandandan could you take look at this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
works towards #22682.
Rationale for this change
There is a lack of testing for multi-dictionary group bys. It make sense to introduce these test before the implementation of
Dict<K,V>in #23187What changes are included in this PR?
introduces a couple test
Dict<_,largeutf8>dict<_,_>Are these changes tested?
the changes are test.
Are there any user-facing changes?
no