Skip to content

fix: support RANGE window frames with binary ORDER BY (#24327) #24344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
waterWang wants to merge 1 commit into from
+23 −0
Closed

fix: support RANGE window frames with binary ORDER BY (#24327) #24344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions datafusion/optimizer/src/analyzer/type_coercion.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,6 +1069,8 @@ fn extract_window_frame_target_type(col_type: &DataType) -> Result<DataType> {
if col_type.is_numeric()
|| col_type.is_string()
|| col_type.is_null()
|| col_type.is_binary()
|| col_type.is_fixed_size_binary()
|| matches!(
col_type,
DataType::List(_)
Expand Down Expand Up @@ -1109,12 +1111,33 @@ fn coerce_window_frame(
}
WindowFrameUnits::Rows | WindowFrameUnits::Groups => DataType::UInt64,
};
// For RANGE frames on binary types, finite offsets (e.g. RANGE BETWEEN 1
// PRECEDING) are not supported because they require arithmetic on the
// order key. Free RANGE frames (only UNBOUNDED / CURRENT ROW) are fine.
if window_frame.units == WindowFrameUnits::Range
&& (target_type.is_binary() || target_type.is_fixed_size_binary())
&& (has_finite_offset(&window_frame.start_bound)
|| has_finite_offset(&window_frame.end_bound))
{
return plan_err!(
"RANGE frame with finite offset is not supported for binary ORDER BY type: {target_type}"
);
}
window_frame.start_bound =
coerce_frame_bound(&target_type, window_frame.start_bound)?;
window_frame.end_bound = coerce_frame_bound(&target_type, window_frame.end_bound)?;
Ok(window_frame)
}

/// Returns true if the window frame bound is a finite offset (not UNBOUNDED
/// or CURRENT ROW).
fn has_finite_offset(bound: &WindowFrameBound) -> bool {
match bound {
WindowFrameBound::Preceding(v) | WindowFrameBound::Following(v) => !v.is_null(),
WindowFrameBound::CurrentRow => false,
}
}

// Support the `IsTrue` `IsNotTrue` `IsFalse` `IsNotFalse` type coercion.
// The above op will be rewrite to the binary op when creating the physical op.
fn get_casted_expr_for_bool_op(expr: Expr, schema: &DFSchema) -> Result<Expr> {
Expand Down