FINERACT-2410: Rework ProgressiveEMICalculator to work only with DTOs#5380
Open
a7med3del1973 wants to merge 1 commit intoapache:developfrom
Conversation
Contributor
|
Please make sure to squash and commit your changes (only 1 commit per PR) |
Contributor
|
7faa8e4 to
850c2ae
Compare
adamsaghy
reviewed
Feb 2, 2026
...ressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/EMICalculator.java
Show resolved
Hide resolved
1fc79b6 to
2fa563e
Compare
adamsaghy
reviewed
Feb 11, 2026
...ressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/EMICalculator.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Feb 11, 2026
...ressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/EMICalculator.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Feb 11, 2026
...an/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/EMICalculatorDataMapper.java
Show resolved
Hide resolved
2fa563e to
b5c68d0
Compare
b5c68d0 to
876579a
Compare
Contributor
|
@a7med3del1973 Please rebase and check the failing checks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.