Skip to content

FINERACT-2410: Rework ProgressiveEMICalculator to work only with DTOs#5380

Open
a7med3del1973 wants to merge 1 commit intoapache:developfrom
a7med3del1973:FINERACT-2410/Rework_ProgressiveEMICalculator_to_work_only_with_DTOs
Open

FINERACT-2410: Rework ProgressiveEMICalculator to work only with DTOs#5380
a7med3del1973 wants to merge 1 commit intoapache:developfrom
a7med3del1973:FINERACT-2410/Rework_ProgressiveEMICalculator_to_work_only_with_DTOs

Conversation

@a7med3del1973
Copy link
Contributor

@a7med3del1973 a7med3del1973 commented Jan 24, 2026

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@airajena
Copy link
Contributor

Please make sure to squash and commit your changes (only 1 commit per PR)

@adamsaghy
Copy link
Contributor

> Task :fineract-progressive-loan:compileTestJava
/home/runner/work/fineract/fineract/fineract-progressive-loan/src/test/java/org/apache/fineract/portfolio/loanproduct/calc/ProgressiveEMICalculatorTest.java:5060: error: [UnusedMethod] Method 'repayment' is never used.
    private static LoanScheduleModelRepaymentPeriod repayment(int periodNumber, LocalDate fromDate, LocalDate dueDate) {
                                                    ^
    (see https://errorprone.info/bugpattern/UnusedMethod)
  Did you mean to remove this line?
/home/runner/work/fineract/fineract/fineract-progressive-loan/src/test/java/org/apache/fineract/portfolio/loanproduct/calc/ProgressiveEMICalculatorTest.java:5070: error: [UnusedMethod] Method 'toScheduleModelPeriodDataList' is never used.
    private static List<ScheduleModelPeriodData> toScheduleModelPeriodDataList(List<LoanScheduleModelRepaymentPeriod> periods) {
              

@a7med3del1973 a7med3del1973 force-pushed the FINERACT-2410/Rework_ProgressiveEMICalculator_to_work_only_with_DTOs branch from 7faa8e4 to 850c2ae Compare January 28, 2026 20:51
@a7med3del1973 a7med3del1973 force-pushed the FINERACT-2410/Rework_ProgressiveEMICalculator_to_work_only_with_DTOs branch 7 times, most recently from 1fc79b6 to 2fa563e Compare February 6, 2026 19:42
@a7med3del1973 a7med3del1973 force-pushed the FINERACT-2410/Rework_ProgressiveEMICalculator_to_work_only_with_DTOs branch from 2fa563e to b5c68d0 Compare February 13, 2026 18:16
@a7med3del1973 a7med3del1973 force-pushed the FINERACT-2410/Rework_ProgressiveEMICalculator_to_work_only_with_DTOs branch from b5c68d0 to 876579a Compare February 13, 2026 21:30
@adamsaghy
Copy link
Contributor

@a7med3del1973 Please rebase and check the failing checks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants