FINERACT-2455: Add Working Capital Loan module#5512
Conversation
| <persistence-unit name="jpa-pu" transaction-type="RESOURCE_LOCAL"> | ||
| <provider>org.eclipse.persistence.jpa.PersistenceProvider</provider> | ||
|
|
||
| <!-- Core Module Entities --> |
There was a problem hiding this comment.
do we need all the classes here for this module?
There was a problem hiding this comment.
I worked ahead a little bit.
For static weaving all entities which are used in this module shall be listed.
It's quite easy to forget, so we had these curated lists about the available entities in the modules and they are just simply listed, even if they are not used.
My 2 cents were "no harm was done" and its quite easy just copy-paste.
What do you think?
There was a problem hiding this comment.
That's fine, I had another approach with the loan originator, but it is a little bit different in this case.
| project(path: ':fineract-avro-schemas') | ||
| ) | ||
|
|
||
| implementation( |
There was a problem hiding this comment.
we could incrementally add dependencies later, I see a lot of them which is unused
There was a problem hiding this comment.
Kind of the same... went a little ahead and just added the dependencies which will be used by #5483
adamsaghy
force-pushed
the
FINERACTR-2455/add-new-module
branch
from
3b7168f to
a004d31
Compare
2 participants
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.