FINERACT-2081: add api verification workflow#5515
Conversation
94e2b34 to
1292e45
Compare
1292e45 to
495cdad
Compare
7df1764 to
97f1dd7
Compare
|
@budaidev how do we fix then when something in the current openapi descriptor when some entryreally doesn't make any sense? how's that then supposed to work? I understand that this plugin is supposed to halt everything if there is a diff between the baseline and the current descriptor... but this covers the whole thing... and there are some corners that are really in need of some touch ups. I agree applying this to the critical path endpoints... but let's say SMS campaign? thanks |
|
@vidakovic that's an excellent question. The basic idea, that this check is not a strict must-have check, but more like an informative check. If we break a working API solution, we should be aware of it.
You can choose any of these solutions listed, or you can decide to just ignore this error as a whole. It's a good idea to include this topic to the documentation once it is ready. |
| with open(os.environ['GITHUB_STEP_SUMMARY'], 'a') as f: | ||
| f.write('## Breaking API Changes Detected\n\n') | ||
| f.write(body) | ||
| f.write('\n\n> **Note:** This check is informational only and does not block the PR.\n') |
There was a problem hiding this comment.
I really like the breaking part, curious to see how it shows comment as an example. Like temporarily pushing breaking change to trigger check?
There was a problem hiding this comment.
The comment part ia tricky because it doesn't have permission in this PR, only after the merge. I tested the breaking change and the summary worked fine.
You can also make a commit to check and revert after you see the result, it won't break anything in the end.
There was a problem hiding this comment.
Understandable as it will show only after merge, but is there is any PR you created in your fork so that i can cross verify.
There was a problem hiding this comment.
You can check it on the fork directly (now the develop is out sync, so it shows error):
openMF#191
|
Thanks for sharing
…On Sun, Feb 22, 2026, 2:24 AM budaidev ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/verify-api-backward-compatibility.yml
<#5515 (comment)>:
> + body = '\n'.join(lines)
+
+ with open(os.environ['GITHUB_OUTPUT'], 'a') as f:
+ f.write('has_report=true\n')
+
+ report_file = '${GITHUB_WORKSPACE}/breaking-changes-report.md'
+ with open(report_file, 'w') as f:
+ f.write('## Breaking API Changes Detected\n\n')
+ f.write(body)
+ f.write('\n\n> **Note:** This check is informational only and does not block the PR.\n')
+
+ # Also write to step summary
+ with open(os.environ['GITHUB_STEP_SUMMARY'], 'a') as f:
+ f.write('## Breaking API Changes Detected\n\n')
+ f.write(body)
+ f.write('\n\n> **Note:** This check is informational only and does not block the PR.\n')
You can check it on the fork directly (now the develop is out sync, so it
shows error):
openMF#191 <openMF#191>
—
Reply to this email directly, view it on GitHub
<#5515 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHV6TAZMY5BRKI3SVQMJF3D4NDAWRAVCNFSM6AAAAACVTN4DKSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQMZWGAYDONBVG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
81245e5 to
4887c15
Compare
4887c15 to
1b6c378
Compare
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.