Repository navigation
fix(javascript): improve hps string writing - #4098
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
chaokunyang
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves how the JavaScript hps string writer handles buffers:
BinaryWriterreserves space before using the hps string path.@apache-fory/hpswrapper validates the destination buffer.Uint8Arrayview offset.Adds tests in
test/hps.test.ts.Note: the hps addon only builds on Node 20, and the JS CI matrix runs Node 18 and 24, so the hps tests are skipped in CI. Verified locally with
npm teston Node 20 (391 tests passed).🤖 Generated with Claude Code