[FREEMARKER-209] Fix "estabilished" typo in error message#126
Merged
ddekany merged 1 commit intoapache:2.3-gaefrom Apr 19, 2026
Merged
Conversation
Corrects spelling in the naming-convention mismatch error message emitted by the FTL parser, and in a related code comment in the same token-manager section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes FREEMARKER-209 — the naming-convention mismatch error message emitted by the FTL parser contains the misspelling "estabilished". This PR corrects it to "established" and also fixes the same typo in a related code comment a few lines above.
Changes
freemarker-core/src/main/javacc/freemarker/core/FTL.jj:680— commentfreemarker-core/src/main/javacc/freemarker/core/FTL.jj:751— user-facing error messageTwo-line diff in a single file. No test or identifier changes.
Scope note
The same typo also appears in the field name
namingConventionEstabilisher(FTL.jj:647 and six usages). I left that rename out of this PR to keep the diff minimal and scoped to the ticket. Happy to do it as a follow-up if maintainers prefer.Verification
./gradlew buildpasses locally (JDK 21, since Gradle 8.5 doesn't recognize newer JDKs).FMParserTokenManager.javacontains the corrected string.CamelCaseTestexercises this exact error path; its assertions still pass because they don't pin the misspelling.Test plan
./gradlew buildsucceeds"established by auto-detection at "estabilishedin build output