build: install the public headers under iceberg/catalog - #927
Open
plusplusjiajia wants to merge 1 commit into
Open
build: install the public headers under iceberg/catalog#927plusplusjiajia wants to merge 1 commit into
plusplusjiajia wants to merge 1 commit into
Conversation
rest_catalog.h is installed and includes iceberg/catalog/session_catalog.h, but the CMake build never installs the headers directly under src/iceberg/catalog, so any downstream project that consumes the installed package and uses the REST catalog fails to compile: fatal error: iceberg/catalog/session_catalog.h: No such file or directory The Meson build already installs these three headers; only CMake is missing them, and every sibling directory (data, expression, manifest, ...) calls iceberg_install_all_headers.
plusplusjiajia
marked this pull request as ready for review
September 8, 2026 10:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rest_catalog.his installed and includesiceberg/catalog/session_catalog.h, which is not — so a downstream project consuming the installed package and using the REST catalog fails to compile:fatal error: iceberg/catalog/session_catalog.h: No such file or directory
The three headers under
src/iceberg/catalog(session_catalog.h,session_context.h,catalog_util.h) are already installed by the Meson build, and every sibling directory in CMake (data,expression,manifest, …) callsiceberg_install_all_headers. Onlysrc/iceberg/catalog/CMakeLists.txtwas missing the call— another instance of #894.
Verified by installing from
mainand building a downstreamfind_package(iceberg CONFIG REQUIRED COMPONENTS bundle rest)project that includesrest_catalog.h: it fails before this change and builds after.