fix: stack overflow when loading large equality deletes #1915
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
A stack overflow occurs when processing data files containing a large number of equality deletes (e.g., > 6000 rows).
This happens because parse_equality_deletes_record_batch_stream previously constructed the final predicate by linearly calling .and() in a loop:
This resulted in a deeply nested, left-skewed tree structure with a depth equal to the number of rows (N). When rewrite_not() (which uses a recursive visitor
pattern) was subsequently called on this structure, or when the structure was dropped, the call stack limit was exceeded.
Changes
pairwise combination approach to build a balanced tree. This reduces the tree depth from O(N) to O(log N).
predicates and avoids traversing a massive unoptimized tree later.
Are these changes tested?