feat(datafusion): CREATE TABLE + DROP TABLE + SLT + IdAssigner #1917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTTY
commented
Dec 10, 2025
|
|
||
| # Insert data to verify table works | ||
| query I | ||
| INSERT INTO default.default.test_create_simple VALUES (1, 'test') |
Collaborator
Author
There was a problem hiding this comment.
I think we don't need to insert here. Right now these slts are bits of everything mixed up. Need to come up with a way to clearly separate them
CTTY
commented
Dec 10, 2025
| /// This struct implements BFS traversal to assign field IDs level-by-level, | ||
| /// similar to how `ReassignFieldIds` works in the spec module. All fields at | ||
| /// one level are assigned IDs before descending to nested fields. | ||
| pub(super) struct ArrowSchemaIdAssigner { |
Collaborator
Author
There was a problem hiding this comment.
Maybe we should just move this to schema.rs? Also I'm planning to revisit this class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
IcebergSchemaProvider::register_table()IcebergSchemaProvider::deregister_table()Are these changes tested?
Added slt