ci: cache key hygiene improvements + cache clippy & msrv#2833
Open
abnobdoss wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Adds
ImageOSandhashFilesto everyrust-cachekey, disables the built-in environment hash, and adds caches toclippyandmsrv.clippyandmsrvhave no cache and compile the full dep graph from scratch every run (227-271s each, compared to ~100s for cached build jobs).The built-in environment hash includes all installed Rust toolchains, not just the one the job uses. Background runner-image changes (toolchain updates, image rolls, env var differences) silently change the hash and cause cache misses. For example, between July 15-16 runners rolled from preinstalled Rust 1.96 to 1.97, and in run 29465370996 jobs within the same CI run landed on different image versions, so some hit the cache and some missed, even though the actual build toolchain hadn't changed.
Replacing the environment hash with
ImageOSandhashFilesover the workflow YAML, Makefile, and Cargo.toml keys the cache on what the build actually depends on.Are these changes tested?