chore(lint) check unused_qualifications#2839
Merged
blackmwk merged 2 commits intoJul 17, 2026
Merged
Conversation
xanderbailey
changed the title
xanderbailey
force-pushed
the
xb/check_unused_qualifications
branch
from
July 17, 2026 07:52
26e6f19 to
a0e82b0
Compare
blackmwk
reviewed
Jul 17, 2026
blackmwk
left a comment
blackmwk
left a comment
Contributor
There was a problem hiding this comment.
Thanks @xanderbailey for this pr, I want it for a long time, relly appreciate it!
xanderbailey
force-pushed
the
xb/check_unused_qualifications
branch
from
July 17, 2026 08:00
5c268eb to
545b32e
Compare
blackmwk
approved these changes
Jul 17, 2026
blackmwk
left a comment
blackmwk
left a comment
Contributor
There was a problem hiding this comment.
Thanks @xanderbailey for this pr!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We have inconsistency across the repo when it comes to using
used_qualificationswhich makes code harder to read and maintain in a consistent style.I did an audit of some popular crate to see if other folks enforce this lint and I found that our friends in the Datafusion community do use this apache/datafusion#13086. But also aware that repos like tokio choose not to.
What changes are included in this PR?
This PR adds
unused_qualifications = "deny"to the rootCargo.tomlAre these changes tested?