JAMES-4166 Supports collapseThread on top of OpenSearch

[quantranhong1999]

No description provided.

[chibenwa]

Ok for the technical capabilities,

Not ok for the API interface side that needs rework ^^

[Arsnael]

Read it!

[quantranhong1999]

Not ok for the API interface side that needs rework ^^

What do you suggest then? If it is SearchOption POJO cf linagora#5506, should we refactor the API interface in another PR?

[chibenwa]

Not adding a MailboxManager method that's for sure.

should we refactor the API interface in another PR?

I'd prefer the refactorings to be a preliminary work actually

Also we said collapseThread should be a property of SearchQuery POJO, and Let's use a collapse for messageId dedup

I think the changeset would be easier with those.

Suggestion:

• Start 1. by using collapse for email Id and drop scroll for JMAP
• Second 2. Modify the search API with SearchOptions and push the offsets onto the search engine
• Third 3. add collapseTHread options onto Search query, implement openSearch, with search enging low level tests
• Fourth 4. Expose this fully onto the JMAP layer

4 small incremental steps that each individually adds value.

Opinion @quantranhong1999 ?

[quantranhong1999]

I'd prefer the refactorings to be a preliminary work actually

Ok to me.

Start 1. by using collapse for email Id and drop scroll for JMAP
Second 2. Modify the search API with SearchOptions and push the offsets onto the search engine

I would focus on refactoring these first in another PR, and come back to rework this OpenSearch PR later then.

[quantranhong1999]

Reworked on top of the refactored search API.

[chibenwa]

Very good job !

[Arsnael]

Read it nothing to add