Skip to content

Prevent too aggressive reuse of interfaces used for Plexus/Sisu #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwin merged 2 commits into from
May 12, 2026
+14 −5
Merged

Prevent too aggressive reuse of interfaces used for Plexus/Sisu #147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecc9f1c
Prevent too aggressive reuse of interfaces used for Plexus/Sisu
kwin May 12, 2026
a55d285
cleanup javadoc
kwin May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/main/java/org/apache/maven/reporting/exec/DefaultMavenReportExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,15 +112,24 @@ public class DefaultMavenReportExecutor implements MavenReportExecutor {
private final PluginVersionResolver pluginVersionResolver;

/**
* All packages which are imported from the Site plugin ClassRealm to the report plugin ClassRealm.
* This should correlate to the list of artifacts excluded via {@link #EXCLUDES} (although imports are always considered first).
* All packages which are imported from the Site plugin ClassRealm to the report plugin ClassRealm, overriding classes/packages from the actual report plugin classloader if any. <br>
* This should correlate to the list of artifacts excluded via {@link #EXCLUDES} (imports are always considered first).
* The given package names are used as prefix, so all classes/resources from the given packages and their sub-packages are imported.
*
* The order of loading is the following:
* <ol>
* <li>imported classes/resources from the Site plugin ClassRealm (only the ones from the given packages/classes)</li>
* <li>classes/resources from the report plugin ClassRealm (except the ones from the given packages)</li>
* <li>classes/resources from the parent ClassLoader (Site plugin ClassRealm) (except from the EXCLUDED artifacts).</li>
* </ol>
*/
private static final List<String> IMPORTS = Arrays.asList(
"org.apache.maven.reporting",
"org.apache.maven.doxia.siterenderer",
"org.apache.maven.doxia.macro",
"org.apache.maven.doxia.parser",
// prevent Macros/ParserModules from being imported and excluded as otherwise they might be registered
// twice in the MacroManager/ParserModuleManager (not separated between m-site-p and reporting-p)
// as both would implement the same interface from the m-s-p classloader
// use those in the versions being referenced in the reporting-plugin
"org.apache.maven.doxia.sink",
"org.apache.maven.doxia.util");

Expand All @@ -129,7 +138,7 @@ public class DefaultMavenReportExecutor implements MavenReportExecutor {
* This must correlate to the list of packages imported in {@link #IMPORTS}.
*/
private static final List<String> EXCLUDES =
Arrays.asList("doxia-sink-api", "doxia-core", "doxia-site-renderer", "maven-reporting-api");
Arrays.asList("doxia-sink-api", "doxia-site-renderer", "maven-reporting-api");

@Inject
public DefaultMavenReportExecutor(
Expand Down
Loading