Skip to content

Upgrade to Doxia 2.1.0#1269

Draft
kwin wants to merge 1 commit into
masterfrom
feature/doxia-2.1.0-new
Draft

Upgrade to Doxia 2.1.0#1269
kwin wants to merge 1 commit into
masterfrom
feature/doxia-2.1.0-new

Conversation

@kwin
Copy link
Copy Markdown
Member

@kwin kwin commented Apr 24, 2026

Upgrade to Reporting Exec 2.0.1
Upgrade IT to maven-changes-plugin 3.0 due to
apache/maven-doxia#1054 and apache/maven-reporting-exec#141.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Upgrade to Reporting Exec 2.0.1
Upgrade IT to maven-changes-plugin 3.0 due to
apache/maven-doxia#1054 and
apache/maven-reporting-exec#141.
@kwin
Copy link
Copy Markdown
Member Author

kwin commented May 11, 2026

This fails in certain ITs due to Doxia Modules being loaded multiple times with stack traces like this:

Caused by: org.apache.maven.doxia.siterenderer.RendererException: File '/Users/715508/git/maven/maven-site-plugin/target/it/site-jar/src/site/apt/download.apt.vm' clashes with existing '/Users/715508/git/maven/maven-site-plugin/target/it/site-jar/src/site/apt/download.apt.vm'.
    at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.lambda$checkForDuplicate$0 (DefaultSiteRenderer.java:317)
    at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.checkForDuplicate (DefaultSiteRenderer.java:361)
    at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.checkForDuplicate (DefaultSiteRenderer.java:333)
    at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.addModuleFiles (DefaultSiteRenderer.java:281)
    at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.locateDocumentFiles (DefaultSiteRenderer.java:202)
    at org.apache.maven.plugins.site.render.AbstractSiteRenderingMojo.locateDocuments (AbstractSiteRenderingMojo.java:455)
    at org.apache.maven.plugins.site.render.SiteMojo.renderLocale (SiteMojo.java:151)
    at org.apache.maven.plugins.site.render.SiteMojo.execute (SiteMojo.java:125)

In that case each module is being called multiple times due to it being bound more than once in DefaultParserModuleManager (eclipse-sisu/sisu-project#253).

Once the Doxia modules are loaded from ClassRealm[plugin>org.apache.maven.plugins:maven-project-info-reports-plugin:3.9.0, parent: ClassRealm[plugin>org.apache.maven.plugins:maven-site-plugin:3.22.0-SNAPSHOT, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@c387f44]] and once from ClassRealm[plugin>org.apache.maven.plugins:maven-site-plugin:3.22.0-SNAPSHOT, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@c387f44]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant