Skip to content

Conversation

@dasTanmoy0096
Copy link

@dasTanmoy0096 dasTanmoy0096 commented Dec 24, 2025

Update dependencies: bump LSP4J to 0.24.0 and Xtext to 2.32.0, replace deprecated API usages.
Further cleaned up some Tests to better conform to changes in newer versions of LSP4J.

Since #9098 kept failing due to incorrect email in commit header, I closed the previous PR and raised this one.


Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

Update dependencies: bump LSP4J to 0.24.0 and Xtext to 2.32.0, replace deprecated API usages.
Further cleaned up some Tests to better conform to changes in newer versions of LSP4J.
@mbien mbien added LSP [ci] enable Language Server Protocol tests Upgrade Library Library (Dependency) Upgrade ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Dec 24, 2025
@apache apache locked and limited conversation to collaborators Dec 24, 2025
@apache apache unlocked this conversation Dec 24, 2025
@dasTanmoy0096
Copy link
Author

Just curious, what happens when all tests pass, I believe a review process happens?

@matthiasblaesing
Copy link
Contributor

@dasTanmoy0096 the process is less formal. Commits need at least one NetBeans committer to merge. It is a judgement call to merge. The unittests give a first indicator, review of the changes and potentially testing give the second factor.

The process is not necessarily limited to a single reviewer. Depending on the scope of the changes secondary opinions can be requested or other people chime in based on their area of interest.

Please indicate how you tested the changes.

Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense to me. The typescript integration still works, so I assume the client changes are fine.

@MartinBalin could you please have a look at the lsp.server changes? These look sane to me, but I don't use the LSP, so someone from that area would be good to have a look.

@mbien mbien added this to the NB29 milestone Dec 27, 2025
@mbien
Copy link
Member

mbien commented Dec 27, 2025

I've put the dependencies into a pom to check the dependency tree for surprises and it should be fine I think. gson is in range and guava is is fine too. (although it wouldn't hurt to update them separately at some point)

Details
    <dependencies>
        <dependency>
            <groupId>org.eclipse.lsp4j</groupId>
            <artifactId>org.eclipse.lsp4j</artifactId>
            <version>0.24.0</version>
        </dependency>
        <dependency>
            <groupId>org.eclipse.lsp4j</groupId>
            <artifactId>org.eclipse.lsp4j.generator</artifactId>
            <version>0.24.0</version>
        </dependency>
        <dependency>
            <groupId>org.eclipse.lsp4j</groupId>
            <artifactId>org.eclipse.lsp4j.jsonrpc</artifactId>
            <version>0.24.0</version>
        </dependency>
        <dependency>
            <groupId>org.eclipse.lsp4j</groupId>
            <artifactId>org.eclipse.lsp4j.debug</artifactId>
            <version>0.24.0</version>
        </dependency>
        <dependency>
            <groupId>org.eclipse.lsp4j</groupId>
            <artifactId>org.eclipse.lsp4j.jsonrpc.debug</artifactId>
            <version>0.24.0</version>
        </dependency>

        <dependency>
            <groupId>org.eclipse.xtend</groupId>
            <artifactId>org.eclipse.xtend.lib</artifactId>
            <version>2.32.0</version>
        </dependency>
        <dependency>
            <groupId>org.eclipse.xtend</groupId>
            <artifactId>org.eclipse.xtend.lib.macro</artifactId>
            <version>2.32.0</version>
        </dependency>

        <dependency>
            <groupId>org.eclipse.xtext</groupId>
            <artifactId>org.eclipse.xtext.xbase.lib</artifactId>
            <version>2.32.0</version>
        </dependency>
    </dependencies>
--- toolbox:0.15.0:tree (default-cli) @ mavenproject1 ---
dev.mbien:mavenproject1:jar:0.1-SNAPSHOT (origin: central)
+- org.eclipse.lsp4j:org.eclipse.lsp4j:jar:0.24.0 [compile] (origin: central)
+- org.eclipse.lsp4j:org.eclipse.lsp4j.generator:jar:0.24.0 [compile] (origin: central)
+- org.eclipse.lsp4j:org.eclipse.lsp4j.jsonrpc:jar:0.24.0 [compile] (origin: central)
|  \- com.google.code.gson:gson:jar:2.13.2 [compile] (range '[2.9.1,3.0)') (origin: central)
|     \- com.google.errorprone:error_prone_annotations:jar:2.41.0 [compile] (origin: central)
+- org.eclipse.lsp4j:org.eclipse.lsp4j.debug:jar:0.24.0 [compile] (origin: central)
+- org.eclipse.lsp4j:org.eclipse.lsp4j.jsonrpc.debug:jar:0.24.0 [compile] (origin: central)
+- org.eclipse.xtend:org.eclipse.xtend.lib:jar:2.32.0 [compile] (origin: central)
+- org.eclipse.xtend:org.eclipse.xtend.lib.macro:jar:2.32.0 [compile] (origin: central)
\- org.eclipse.xtext:org.eclipse.xtext.xbase.lib:jar:2.32.0 [compile] (origin: central)
   \- com.google.guava:guava:jar:32.1.2-jre [compile] (origin: central,sonatype-snapshots)
      +- com.google.guava:failureaccess:jar:1.0.1 [compile] (origin: central,sonatype-snapshots)
      +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava [compile] (origin: central,sonatype-snapshots)
      +- com.google.code.findbugs:jsr305:jar:3.0.2 [compile] (origin: central,sonatype-snapshots)
      +- org.checkerframework:checker-qual:jar:3.33.0 [compile] (origin: central,sonatype-snapshots)
      \- com.google.j2objc:j2objc-annotations:jar:2.8 [compile] (origin: central,sonatype-snapshots)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) LSP [ci] enable Language Server Protocol tests Upgrade Library Library (Dependency) Upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants