Skip to content

Conversation

@yangsong8-a1
Copy link
Contributor

Summary

Optimize and update adb-related configurations.

Impact

Optimize and update adb-related configurations.

Testing

Host: ubuntu 22.04.1
Target: sim and tricore device

Without this configuration, when executing exit in adb shell,
adb will not be able to exit because it cannot receive the
close packet.

Signed-off-by: yangsong8 <[email protected]>
acassis
acassis previously approved these changes Dec 8, 2025
Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yangsong8-a1 :-)

Git commit message is required, thus CI fail, please update :-)

@yangsong8-a1
Copy link
Contributor Author

Thank you @yangsong8-a1 :-)

Git commit message is required, thus CI fail, please update :-)

thank you :-)

xiaoxiang781216
xiaoxiang781216 previously approved these changes Dec 9, 2025
@cederom
Copy link
Contributor

cederom commented Dec 9, 2025

@xiaoxiang781216
Copy link
Contributor

@yangsong8-a1 please update sim/adb defconfig to fix the ci error:

====================================================================================
Configuration/Tool: sim/adb
2025-12-09 11:30:32
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Building NuttX...
Cloning into 'tlsf/tlsf'...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

100 44130  100 44130    0     0  843[92](https://github.com/apache/nuttx-apps/actions/runs/20050541456/job/57540427987#step:10:93)      0 --:--:-- --:--:-- --:--:-- 84392

100 1646k    0 1646k    0     0  2737k      0 --:--:-- --:--:-- --:--:-- 2737k
  [1/1] Normalize sim/adb
13d12
< CONFIG_ADBD_TCP_SERVER=y
Saving the new configuration file
On branch master
Your branch is up to date with 'origin/master'.

For TCP-based adb, if the current CPU contains TCP protocol stack,
then NET_TCPBACKLOG needs to be enabled.

Signed-off-by: yangsong8 <[email protected]>
@yangsong8-a1
Copy link
Contributor Author

update defconfig patch : apache/nuttx#17471

@cederom
Copy link
Contributor

cederom commented Dec 10, 2025

update defconfig patch : apache/nuttx#17471

Thank you @yangsong8-a1 :-) @xiaoxiang781216 will merge dependencies soon.. maybe CI restart here is enough or the rebase will be necessary if that fails :-)

@cederom
Copy link
Contributor

cederom commented Dec 10, 2025

CI failed again, I have restarted all jobs. Maybe rebase is required?

@yangsong8-a1
Copy link
Contributor Author

thank you :-)

@xiaoxiang781216
Copy link
Contributor

CI failed again, I have restarted all jobs. Maybe rebase is required?

@cederom ci pass now.

Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yangsong8-a1 and @xiaoxiang781216 :-)

@xiaoxiang781216 xiaoxiang781216 merged commit 60f5a68 into apache:master Dec 11, 2025
82 of 114 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants