HDDS-14398. Create ObjectOperationHandler interface#9683
Merged
adoroszlai merged 2 commits intoapache:masterfrom Jan 30, 2026
Merged
HDDS-14398. Create ObjectOperationHandler interface#9683adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
peterxcli
approved these changes
Jan 28, 2026
...s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectOperationHandlerChain.java
Show resolved
Hide resolved
peterxcli
approved these changes
Jan 29, 2026
Member
peterxcli
left a comment
There was a problem hiding this comment.
LGTM +1 again. Thanks for the prompt update
ivandika3
approved these changes
Jan 30, 2026
Contributor
ivandika3
left a comment
There was a problem hiding this comment.
@adoroszlai Thanks for the substantial improvement. LGTM +1.
Contributor
Author
|
Thanks @ivandika3, @peterxcli for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
First step towards splitting
ObjectEndpoint:BucketOperationHandler.PUTrequest for now:ObjectEndpointitself implement the new interface to handle remaining branches ofPUTrequest (to be moved to separate handlers later).OzoneVolumeandOzoneBucketonly if needed and at most onceS3GActionfor audit logging back to the callerThis is a bit different from
BucketOperationHandler, where each implementation is currently responsible for its own audit logging. I plan to refactor that to reduce duplication.https://issues.apache.org/jira/browse/HDDS-14398
How was this patch tested?
Existing tests.
https://github.com/adoroszlai/ozone/actions/runs/21434541033