[python] add error handling to abort pending commits and serialization support for ray sink #7022
+808
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please add description. |
XiaoHongbo-Hope
force-pushed
the
ray_sink
branch
from
b6edff8 to
774fdc1
Compare
XiaoHongbo-Hope
force-pushed
the
ray_sink
branch
from
774fdc1 to
5061461
Compare
XiaoHongbo-Hope
changed the title
XiaoHongbo-Hope
changed the title
Contributor
Author
Added. |
XiaoHongbo-Hope
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add error handling to abort pending commits on failures and and write method to create WriteBuilder on each worker.
Changes:
Update write method: create WriteBuilder on worker instead of using driver's builder
Add abort logic in on_write_complete() and on_write_failed() methods
Add _pending_commit_messages tracking and serialization support
Tests
ray_sink_testAPI and Format
pyhton-api.md
Documentation