Replace @Test(expected=...) with assertThatThrownBy() checks#3636
Open
nastra wants to merge 2 commits into
Open
Replace @Test(expected=...) with assertThatThrownBy() checks#3636nastra wants to merge 2 commits into
nastra wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Replaced the old
@Test(expected = SomeException.class)patterns in the tests withassertThatThrownBy(...), asserting on both the exception type and the messageThe reason for the change is because
@Test(expected = SomeException.class)can't assert on the exception message at all. Also, it's not clear which statement in the entire test method threw the exception, so a test could pass for the wrong reasonWhat changes are included in this PR?
Are these changes tested?
yes, existing tests
Are there any user-facing changes?
no