GH-3637: Fix corrupt output when reusing a dictionary writer across row groups after fallback#3638
Open
nastra wants to merge 2 commits into
Open
GH-3637: Fix corrupt output when reusing a dictionary writer across row groups after fallback#3638nastra wants to merge 2 commits into
nastra wants to merge 2 commits into
Conversation
…ross row groups after fallback
Contributor
Author
nastra
force-pushed
the
fallback-values-writer
branch
from
b902b8e to
03b2e44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When using the
FallbackValuesWriter, after a fallback,currentWriteris the fallback writer, so the initial dictionary writer is never reset at row-group boundaries, which can silently corrupt the next row group.Closes #3637
What changes are included in this PR?
Are these changes tested?
added two tests that reproduce the issue and fail without the fix
Are there any user-facing changes?
no