Throw IAE when dealing with odd-length/invalid hex string in Parquet CLI#3642
Open
nastra wants to merge 1 commit into
Open
Throw IAE when dealing with odd-length/invalid hex string in Parquet CLI#3642nastra wants to merge 1 commit into
nastra wants to merge 1 commit into
Conversation
Contributor
Author
nastra
force-pushed
the
invalid-hex-string
branch
from
a2376f4 to
550e560
Compare
nastra
changed the title
nastra
force-pushed
the
invalid-hex-string
branch
from
550e560 to
9d9994e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This avoids odd-length hex strings being passed, which cause IndexOutOfBoundsExceptions and instead throws IAE to make it clearer that hex string length must be even
What changes are included in this PR?
Are these changes tested?
added tests that reproduce the issue
Are there any user-facing changes?
no