-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[timeseries] Added TimeSeriesBlock based exception propagation #17440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shauryachats
wants to merge
3
commits into
apache:master
Choose a base branch
from
shauryachats:timeseries_errorblock
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+114
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #17440 +/- ##
============================================
- Coverage 63.28% 63.25% -0.04%
Complexity 1474 1474
============================================
Files 3161 3161
Lines 188588 188629 +41
Branches 28857 28864 +7
============================================
- Hits 119351 119309 -42
- Misses 59983 60067 +84
+ Partials 9254 9253 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...-runtime/src/main/java/org/apache/pinot/query/runtime/timeseries/LeafTimeSeriesOperator.java
Show resolved
Hide resolved
...time/src/main/java/org/apache/pinot/query/runtime/timeseries/serde/TimeSeriesBlockSerde.java
Outdated
Show resolved
Hide resolved
...time/src/main/java/org/apache/pinot/query/runtime/timeseries/serde/TimeSeriesBlockSerde.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/response/PinotBrokerTimeSeriesResponse.java
Outdated
Show resolved
Hide resolved
ef45467 to
3162d3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
timeseries-engine
Tracking tag for generic time-series engine work
timeseries-general-availability
Work for making Timeseries Engine GA in Pinot (e.g. Controller UI support, debuggability, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the time series query execution framework to properly propagate and expose query exceptions instead of throwing them, enabling better error handling and reporting for both broker-compatible and Prometheus-compatible APIs.
This enables partial results with warnings instead of complete failures, as well as exceptions from leaf operators visible at the broker level.
The exceptions are encoded in the
metadataMappassed alongside data, and stored inTimeSeriesBlockfor upward propagation.To support partial results for Prometheus-compatible API, this PR also introduces a
warningsfield (as specified in the Prometheus API reference) to expose these warnings correctly.Testing
Added integration test
testQueryWithServerExceptionto verify exception handling for both response formats: