refactor(agent-service): isolate HTTP clients#5753
Draft
bobbai00 wants to merge 2 commits into
Draft
Conversation
…module Foundation slice of the agent-service reorganization (no runtime behavior change): - Add src/types/api.ts (wire DTOs) and src/types/metadata.ts (operator metadata types extracted out of api/backend-api.ts); export both from the types barrel. - Add src/config/endpoints.ts exposing getServiceEndpoints(). - Move src/api/auth-api.ts -> src/auth/jwt.ts (content unchanged) and add src/auth/jwt.test.ts; update auth import paths. - Keep api/backend-api.ts transitional: it now imports/re-exports the metadata types from ../types/metadata and retains getBackendConfig/fetchOperatorMetadata, which the follow-up clients PR relocates. The types/agent.ts and types/workflow.ts reshaping is deferred to the PR that also updates server.ts/workflow-state.ts, since those renames are coupled.
Second slice of the agent-service reorganization (no runtime behavior change): - Rename the per-service HTTP clients to *-client.ts: compile-api -> compile-client, workflow-api -> workflow-client, and split operator-metadata fetching into operator-metadata-client.ts; add a dedicated execution-client.ts for workflow execution calls. All clients now read base URLs via getServiceEndpoints(). - Rewire api/index.ts to the new client modules. - Add unit tests for all four clients. - Add the additive ExecutionRequestParams type (types/agent.ts) and ExecutionMode enum + optional WorkflowSettings.executionMode (types/workflow.ts) needed by the new client and its test; the follow-up server/state PR completes the workflow.ts reshaping and makes executionMode required. - Trim api/backend-api.ts to just getBackendConfig (transitional); the remaining server/tools consumers switch to getServiceEndpoints in the follow-up PR. Consumer changes are import-path-only; no logic was modified.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5753 +/- ##
============================================
+ Coverage 53.04% 53.31% +0.27%
Complexity 2654 2654
============================================
Files 1094 1098 +4
Lines 42295 42367 +72
Branches 4545 4545
============================================
+ Hits 22434 22589 +155
+ Misses 18545 18462 -83
Partials 1316 1316
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Second slice of the agent-service reorganization (no runtime behavior change):
*-client.ts(compile-api→compile-client,workflow-api→workflow-client), split operator-metadata fetching intooperator-metadata-client.ts, and add a dedicatedexecution-client.ts; all clients now read base URLs viagetServiceEndpoints().api/index.ts; add unit tests for all four clients.ExecutionRequestParams(types/agent.ts) and theExecutionModeenum + optionalWorkflowSettings.executionMode(types/workflow.ts). The follow-up server/state PR completes theworkflow.tsreshaping and makesexecutionModerequired.api/backend-api.tsto a transitionalgetBackendConfig; the remaining server/tools consumers switch togetServiceEndpoints()in the follow-up PR.Consumer changes are import-path-only; no logic was modified.
Any related issues, documentation, discussions?
Closes #5749
Part of #5747
How was this PR tested?
bunx tsc --noEmit,bun test(116 pass / 0 fail, including 4 new client test suites), andprettier --checkall pass inagent-service.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.8 (1M context)