Skip to content

refactor(UI): unify dataset card view onto the shared CardItemComponent#5949

Open
xuang7 wants to merge 3 commits into
apache:mainfrom
xuang7:refactor/unify-dataset-card-view
Open

refactor(UI): unify dataset card view onto the shared CardItemComponent#5949
xuang7 wants to merge 3 commits into
apache:mainfrom
xuang7:refactor/unify-dataset-card-view

Conversation

@xuang7

@xuang7 xuang7 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

[Stacked on #5947]

This PR consolidates the public and private dataset listings to use the shared CardItemComponent.

  • Replace texera-dataset-card-item with the shared read-only texera-card-item in the public hub.
  • Remove the unused DatasetCardItemComponent and its tests.
  • Align the hub list/card toggle with the workflow and private dataset listings.
  • Update the like button styling on the shared card.

This keeps dataset cards consistent across all listings and reduces duplicated code.

Demo:
public-datasets

Any related issues, documentation, discussions?

Closes #5948

How was this PR tested?

All existing tests passed, and the changes were manually tested.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Opus 4.8

xuang7 and others added 3 commits June 25, 2026 00:06
@github-actions github-actions Bot added refactor Refactor the code frontend Changes related to the frontend GUI labels Jun 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @Ma77Ball, @Yicong-Huang
    You can notify them by mentioning @Ma77Ball, @Yicong-Huang in a comment.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 47.22222% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.10%. Comparing base (44df4f7) to head (732c926).
⚠️ Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
...nent/user/user-dataset/user-dataset.component.html 0.00% 15 Missing ⚠️
...nt/user/list-item/card-item/card-item.component.ts 75.00% 1 Missing and 2 partials ⚠️
...ponent/user/user-dataset/user-dataset.component.ts 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5949      +/-   ##
============================================
+ Coverage     53.96%   54.10%   +0.13%     
  Complexity     2782     2782              
============================================
  Files          1100     1104       +4     
  Lines         42588    42768     +180     
  Branches       4583     4600      +17     
============================================
+ Hits          22984    23140     +156     
- Misses        18268    18279      +11     
- Partials       1336     1349      +13     
Flag Coverage Δ *Carryforward flag
access-control-service 70.44% <ø> (ø) Carriedforward from 44df4f7
agent-service 34.36% <ø> (ø) Carriedforward from 44df4f7
amber 55.27% <ø> (ø) Carriedforward from 44df4f7
computing-unit-managing-service 1.65% <ø> (ø) Carriedforward from 44df4f7
config-service 57.35% <ø> (ø) Carriedforward from 44df4f7
file-service 57.06% <ø> (ø) Carriedforward from 44df4f7
frontend 48.56% <47.22%> (+0.41%) ⬆️
pyamber 90.19% <ø> (ø) Carriedforward from 44df4f7
python 90.80% <ø> (ø) Carriedforward from 44df4f7
workflow-compiling-service 58.69% <ø> (ø) Carriedforward from 44df4f7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI refactor Refactor the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify dataset card view onto the shared CardItemComponent

2 participants