-
Notifications
You must be signed in to change notification settings - Fork 175
ci: drive website docs from release branches instead of pushing #6948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
702b513
258c638
da4e89b
a15112d
5a9cf3b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -461,3 +461,25 @@ jobs: | |||||||||||||||
| echo "\`\`\`" >> $GITHUB_STEP_SUMMARY | ||||||||||||||||
| cat "$GITHUB_WORKSPACE/vote-email.txt" >> $GITHUB_STEP_SUMMARY | ||||||||||||||||
| echo "\`\`\`" >> $GITHUB_STEP_SUMMARY | ||||||||||||||||
|
|
||||||||||||||||
| # After an RC is published, tell the website to rebuild. The site pulls docs | ||||||||||||||||
| # straight from the release branches, so this is just a "go" signal; the | ||||||||||||||||
| # site's daily schedule is the safety net if this never fires. A | ||||||||||||||||
| # repository_dispatch needs Contents:write on the target repo, so the token's | ||||||||||||||||
| # fine-grained scope must include apache/incubator-texera-site (add that repo | ||||||||||||||||
| # to AUTO_MERGE_TOKEN if it isn't already covered). | ||||||||||||||||
| notify-website: | ||||||||||||||||
| needs: [create-rc, upload-rc] | ||||||||||||||||
| if: github.repository == 'apache/texera' | ||||||||||||||||
| runs-on: ubuntu-latest | ||||||||||||||||
| steps: | ||||||||||||||||
| - name: Trigger website rebuild | ||||||||||||||||
| continue-on-error: true # never fail the release over a website ping | ||||||||||||||||
| env: | ||||||||||||||||
| GH_TOKEN: ${{ secrets.AUTO_MERGE_TOKEN }} | ||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This borrows This PR frees the |
||||||||||||||||
| run: | | ||||||||||||||||
| # Pass the tag and its resolved commit sha. | ||||||||||||||||
| gh api repos/apache/incubator-texera-site/dispatches \ | ||||||||||||||||
| -f event_type=docs-updated \ | ||||||||||||||||
| -f "client_payload[tag]=${{ github.event.inputs.tag }}" \ | ||||||||||||||||
| -f "client_payload[sha]=${{ needs.create-rc.outputs.commit_hash }}" | ||||||||||||||||
|
Comment on lines
+481
to
+485
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Yicong-Huang asked on line 483 how the exact RC SHA reaches the site. The other side says it does not: a paginated sweep of apache/incubator-texera-site#68 finds no Honoring it later would create a new problem. Dispatch builds would pin an RC sha while the daily cron builds the branch tip, so docs would flip between two sources. Suggest dropping the payload and keeping the pure "go" signal.
Suggested change
|
||||||||||||||||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
continue-on-error: truewith no annotation means a 403 — the exact failure mode #6949 exists to fix — produces a green release run. Advisory rather than a defect: the RC workflow is hand-launched and watched, and #68's daily cron caps the staleness at ~24h.Wrapping the call as
if ! gh api …; then echo "::warning::…"; fisurfaces the miss and keeps the release green, makingcontinue-on-errorunnecessary.