Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/create-release-candidate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -461,3 +461,25 @@ jobs:
echo "\`\`\`" >> $GITHUB_STEP_SUMMARY
cat "$GITHUB_WORKSPACE/vote-email.txt" >> $GITHUB_STEP_SUMMARY
echo "\`\`\`" >> $GITHUB_STEP_SUMMARY

# After an RC is published, tell the website to rebuild. The site pulls docs
# straight from the release branches, so this is just a "go" signal; the
# site's daily schedule is the safety net if this never fires. A
# repository_dispatch needs Contents:write on the target repo, so the token's
# fine-grained scope must include apache/incubator-texera-site (add that repo
# to AUTO_MERGE_TOKEN if it isn't already covered).
notify-website:
needs: [create-rc, upload-rc]
if: github.repository == 'apache/texera'
runs-on: ubuntu-latest
steps:
- name: Trigger website rebuild
continue-on-error: true # never fail the release over a website ping

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continue-on-error: true with no annotation means a 403 — the exact failure mode #6949 exists to fix — produces a green release run. Advisory rather than a defect: the RC workflow is hand-launched and watched, and #68's daily cron caps the staleness at ~24h.

Wrapping the call as if ! gh api …; then echo "::warning::…"; fi surfaces the miss and keeps the release green, making continue-on-error unnecessary.

env:
GH_TOKEN: ${{ secrets.AUTO_MERGE_TOKEN }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This borrows AUTO_MERGE_TOKEN, shared with the backport workflows, and the job comment notes its scope must be broadened first. The deleted workflow did the same job through a purpose-scoped SITE_SYNC_TOKEN with a narrow permissions: block — a step back from what the repo already had.

This PR frees the SITE_SYNC_TOKEN name. Pointing the job at it is the same one-time INFRA request, without widening what the backport workflows carry. That request gates either option, so this is not a merge blocker. Worth adding a permissions: block too.

run: |
# Pass the tag and its resolved commit sha.
gh api repos/apache/incubator-texera-site/dispatches \
-f event_type=docs-updated \
-f "client_payload[tag]=${{ github.event.inputs.tag }}" \
-f "client_payload[sha]=${{ needs.create-rc.outputs.commit_hash }}"
Comment on lines +481 to +485

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yicong-Huang asked on line 483 how the exact RC SHA reaches the site. The other side says it does not: a paginated sweep of apache/incubator-texera-site#68 finds no client_payload, and its build runs pull-release-docs.sh against release/vX.Y branch tips.

Honoring it later would create a new problem. Dispatch builds would pin an RC sha while the daily cron builds the branch tip, so docs would flip between two sources. Suggest dropping the payload and keeping the pure "go" signal.

Suggested change
# Pass the tag and its resolved commit sha.
gh api repos/apache/incubator-texera-site/dispatches \
-f event_type=docs-updated \
-f "client_payload[tag]=${{ github.event.inputs.tag }}" \
-f "client_payload[sha]=${{ needs.create-rc.outputs.commit_hash }}"
gh api repos/apache/incubator-texera-site/dispatches \
-f event_type=docs-updated

202 changes: 0 additions & 202 deletions .github/workflows/sync-docs-to-site.yml

This file was deleted.

Loading