[ARITH] Use IntImm in canonical scalar hot paths#19885
Merged
tlopex merged 1 commit intoJun 25, 2026
Merged
Conversation
Canonical simplify operates on scalar index expressions in these paths, so direct IntImm construction avoids the generic MakeConst scalar/vector dispatch. This keeps MakeConst for generic helper sites while streamlining the focused split normal-form constants.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces multiple instances of MakeConst with IntImm in src/arith/canonical_simplify.cc and src/arith/const_fold.h to instantiate integer constants directly. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
tlopex
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Canonical simplify operates on scalar index expressions in these paths, so direct
IntImmconstruction avoids the genericMakeConstscalar/vector dispatch. This keepsMakeConstfor generic helper sites while streamlining the focused split normal-form constants.Main changes:
IntImmfor scalar constants in canonical split/sum normalization and related division/mod pathsModandFloorModconstant-fold zero cases