Skip to content

[TFLite] Use structural checks in frontend tests#19888

Merged
tqchen merged 1 commit into
apache:mainfrom
tlopex:tflite-structural-check
Jun 25, 2026
Merged

[TFLite] Use structural checks in frontend tests#19888
tqchen merged 1 commit into
apache:mainfrom
tlopex:tflite-structural-check

Conversation

@tlopex

@tlopex tlopex commented Jun 25, 2026

Copy link
Copy Markdown
Member

This pr

  • Replaces script-string based TFLite frontend IR checks with structural checks.
  • Keeps numeric/runtime tests focused on VM output validation instead of mixing in structural assertions.
  • Leaves the shared verify helper unchanged and use direct tvm.ir.assert_structural_equal where structural checks are needed.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the TFLite frontend tests by replacing fragile string-based IR assertions with robust structural equality checks against expected TVM Script IR modules. Feedback on the changes highlights two main issues: first, in test_reverse_sequence, the structural assertion was accidentally removed, leaving the expected module unused; second, in test_unique, the runtime execution test was completely replaced by the structural check, and it is recommended to retain both to preserve runtime test coverage.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/python/relax/test_frontend_tflite.py
Comment thread tests/python/relax/test_frontend_tflite.py
@tlopex tlopex force-pushed the tflite-structural-check branch from d913582 to 10f1025 Compare June 25, 2026 07:36
@tqchen tqchen merged commit cb0d55d into apache:main Jun 25, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants