Move JavaCSVTableSource to Java platform and rename to JavaCSVFileSource#696
Move JavaCSVTableSource to Java platform and rename to JavaCSVFileSource#696Chandanakt wants to merge 2 commits intoapache:mainfrom
Conversation
|
Hi @Chandanakt, there were some updates in the specified file, can you pull the changes and resolve conflicts? As I can see from your PR we have some dependency on Calcite which we would have to add in the wayang-java module. Do you think there is a way to avoid that? It would be preferable if Calcite is used only in the SQL module |
|
Hi @zkaoudi , thanks for the feedback. Regarding the Calcite dependency: I agree with your suggestion. I'll refactor the implementation so that the SQL module maps RelDataType to a lightweight internal representation, and JavaCSVFileSource no longer depends on Calcite and will operate only on that representation. This keeps Calcite usage confined to the SQL module while preserving the existing conversion logic. I’ll work on these changes and update the PR shortly. Thanks! |
c0dc1a1 to
088ed83
Compare
|
Hi @zkaoudi , |
This PR moves JavaCSVTableSource from the SQL API module to the
wayang-java platform module and renames it to JavaCSVFileSource.
The helper class CsvRowConverter was also moved accordingly.
No functional changes were introduced.
Fixes #482