Skip to content

Comments

Move JavaCSVTableSource to Java platform and rename to JavaCSVFileSource#696

Open
Chandanakt wants to merge 2 commits intoapache:mainfrom
Chandanakt:move-java-csv-file-source
Open

Move JavaCSVTableSource to Java platform and rename to JavaCSVFileSource#696
Chandanakt wants to merge 2 commits intoapache:mainfrom
Chandanakt:move-java-csv-file-source

Conversation

@Chandanakt
Copy link

This PR moves JavaCSVTableSource from the SQL API module to the
wayang-java platform module and renames it to JavaCSVFileSource.

The helper class CsvRowConverter was also moved accordingly.
No functional changes were introduced.

Fixes #482

@zkaoudi
Copy link
Contributor

zkaoudi commented Feb 23, 2026

Hi @Chandanakt, there were some updates in the specified file, can you pull the changes and resolve conflicts?

As I can see from your PR we have some dependency on Calcite which we would have to add in the wayang-java module. Do you think there is a way to avoid that? It would be preferable if Calcite is used only in the SQL module

@Chandanakt
Copy link
Author

Chandanakt commented Feb 23, 2026

Hi @zkaoudi , thanks for the feedback.
I will rebase my branch on the latest main and resolve any conflicts.

Regarding the Calcite dependency: I agree with your suggestion. I'll refactor the implementation so that the SQL module maps RelDataType to a lightweight internal representation, and JavaCSVFileSource no longer depends on Calcite and will operate only on that representation. This keeps Calcite usage confined to the SQL module while preserving the existing conversion logic.

I’ll work on these changes and update the PR shortly. Thanks!

@Chandanakt Chandanakt force-pushed the move-java-csv-file-source branch from c0dc1a1 to 088ed83 Compare February 23, 2026 18:29
@Chandanakt
Copy link
Author

Hi @zkaoudi ,
I’ve pushed the updated changes.
The SQL module now maps RelDataType to a lightweight CsvType, and JavaCSVFileSource no longer depends on Calcite.
Please let me know if any further adjustments are needed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move JavaCSVTableSource operator from sql-api to the Java platform

2 participants