Skip to content

YETUS-1259. Support detecting Maven Wrapper #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pan3793 wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −4
Open

YETUS-1259. Support detecting Maven Wrapper #361

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc9c87a
Support detecting Maven Wrapper
pan3793 Jan 30, 2026
62639b8
Reorder MAVEN command preference logic
pan3793 Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions precommit/src/main/shell/plugins.d/maven.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@

declare -a MAVEN_ARGS

if [[ -z "${MAVEN_HOME:-}" ]]; then
MAVEN=mvn
else
if [[ -e "${BASEDIR}/mvnw" ]]; then
Copy link
Contributor

@aw-was-here aw-was-here Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add support for windows here

Copy link
Member Author

@pan3793 pan3793 Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aw-was-here, sorry I don't know what I can do here, I glanced gradle.sh, which seems to have no Windows-specific logic for gradlew detection

MAVEN=${BASEDIR}/mvnw
elif [[ -n "${MAVEN_HOME:-}" ]]; then
MAVEN=${MAVEN_HOME}/bin/mvn
else
MAVEN=mvn
fi

MAVEN_CUSTOM_REPOS=false
Expand Down Expand Up @@ -78,7 +80,7 @@ function maven_ws_replace
function maven_usage
{
maven_ws_replace
yetus_add_option "--mvn-cmd=<file>" "The 'mvn' command to use (default \${MAVEN_HOME}/bin/mvn, or 'mvn')"
yetus_add_option "--mvn-cmd=<file>" "The 'mvn' command to use (default \${BASEDIR}/mvnw, \${MAVEN_HOME}/bin/mvn, or 'mvn')"
yetus_add_option "--mvn-custom-repos" "Use per-project maven repos"
yetus_add_option "--mvn-custom-repos-dir=<dir>" "Location of repos, default is '${MAVEN_CUSTOM_REPOS_DIR}'"
yetus_add_option "--mvn-deps-order=<bool>" "Disable maven's auto-dependency module ordering (Default: '${MAVEN_DEPENDENCY_ORDER}')"
Expand Down
Loading