Skip to content

Add missing param type#7313

Merged
soyuka merged 1 commit into
api-platform:mainfrom
VincentLanglet:paramType
Aug 18, 2025
Merged

Add missing param type#7313
soyuka merged 1 commit into
api-platform:mainfrom
VincentLanglet:paramType

Conversation

@VincentLanglet

@VincentLanglet VincentLanglet commented Jul 25, 2025

Copy link
Copy Markdown
Contributor
Q A
Branch? main
Tickets Closes #..., closes #...
License MIT
Doc PR api-platform/docs#...

Hi @soyuka

I forgot about it, but as promised I'll try to fix more phpstan error.
Here, I added every missing parameter type.

It's often phpdoc to unsure BC, because multiple of those method could have work with some other type (because of early return). I only added typehint is mixed or

  • When the class is final
  • The method couldn't have work with another type because it use another method which IS already native typed.

@VincentLanglet VincentLanglet marked this pull request as ready for review July 25, 2025 11:58
@soyuka soyuka merged commit 165040c into api-platform:main Aug 18, 2025
113 of 114 checks passed
@soyuka

soyuka commented Aug 18, 2025

Copy link
Copy Markdown
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants