fix(laravel): belongs-to-many relations dont have a get-foreign-key-name method #7589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariantrifu
changed the title
mariantrifu
force-pushed
the
fix-laravel-metadata
branch
from
5773bcb to
6ed6b21
Compare
soyuka
reviewed
Dec 7, 2025
| $relations = $this->getRelations($model); | ||
|
|
||
| $foreignKeys = array_flip(array_column($relations, 'foreign_key')); | ||
| $foreignKeys = array_flip(array_filter(array_column($relations, 'foreign_key'))); |
Member
There was a problem hiding this comment.
I'd love to have a functional test for this would you be able to add one? Models are inside src/Laravel/workbench/app/Models.
To run the tests see https://github.com/api-platform/core/blob/4a72073573af0740ffb24c7ed1e8a13e36546654/src/Laravel/CONTRIBUTING.md#tests
Contributor
Author
There was a problem hiding this comment.
Sure, I'll try to add that also.
|
Hi , i have same problem , when do you think you can merge ? this fix ? |
Member
|
sure thing is I need to add a test you can also just drop an example of model and request I'll add it (though any llm can do it inside the workbench and the functional tests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Platform library tries to extract the foreign_key from all relations, but BelongsToMany relations don't have a getForeignKeyName() method, so it returns null. When API Platform tries to flip an array containing null values, PHP throws the error: array_flip(): Can only flip string and integer values, entry skipped.