Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Removes the version-derived suffix (e.g., .v0, .v1) from namespaces generated by ServiceConfiguration.applicationNamespace(), so generated package/namespace names remain stable across service versions.
Changes:
- Update
ServiceConfiguration.applicationNamespace()to no longer append the major-version tag. - Update
ServiceConfigurationSpecexpectations to match the new namespace format.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/src/main/scala/ServiceConfiguration.scala | Stops appending the major version tag to generated application namespaces; updates method scaladoc example. |
| lib/src/test/scala/ServiceConfigurationSpec.scala | Updates unit tests to assert namespaces without the .vN suffix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| /** | ||
| * Example: apidocSpec => apidoc.spec.v0 | ||
| * Example: apidocSpec => apidoc.spec |
There was a problem hiding this comment.
The scaladoc example is a bit ambiguous: applicationNamespace always prefixes with orgNamespace and only lower-cases/splits the key. Consider updating the example to show a full input/output (including an orgNamespace like me.apidoc) so readers don’t assume the whole namespace is derived solely from key.
| * Example: apidocSpec => apidoc.spec | |
| * Example: | |
| * orgNamespace = "me.apidoc", key = "apidocSpec" => "me.apidoc.spec" |
Summary
.v0,.v1, etc.) fromServiceConfiguration.applicationNamespace()com.bryzek.chat.v0now becomecom.bryzek.chatTest plan
🤖 Generated with Claude Code