Skip to content

Remove version suffix from generated namespaces#969

Open
mbryzek wants to merge 1 commit intomainfrom
remove-version-namespace
Open

Remove version suffix from generated namespaces#969
mbryzek wants to merge 1 commit intomainfrom
remove-version-namespace

Conversation

@mbryzek
Copy link
Collaborator

@mbryzek mbryzek commented Mar 22, 2026

Summary

  • Remove version suffix (.v0, .v1, etc.) from ServiceConfiguration.applicationNamespace()
  • Namespaces like com.bryzek.chat.v0 now become com.bryzek.chat
  • Tests updated to match new behavior

Test plan

  • All 64 lib tests pass
  • Verify downstream codegen produces correct namespaces

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 22, 2026 03:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the version-derived suffix (e.g., .v0, .v1) from namespaces generated by ServiceConfiguration.applicationNamespace(), so generated package/namespace names remain stable across service versions.

Changes:

  • Update ServiceConfiguration.applicationNamespace() to no longer append the major-version tag.
  • Update ServiceConfigurationSpec expectations to match the new namespace format.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
lib/src/main/scala/ServiceConfiguration.scala Stops appending the major version tag to generated application namespaces; updates method scaladoc example.
lib/src/test/scala/ServiceConfigurationSpec.scala Updates unit tests to assert namespaces without the .vN suffix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


/**
* Example: apidocSpec => apidoc.spec.v0
* Example: apidocSpec => apidoc.spec
Copy link

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scaladoc example is a bit ambiguous: applicationNamespace always prefixes with orgNamespace and only lower-cases/splits the key. Consider updating the example to show a full input/output (including an orgNamespace like me.apidoc) so readers don’t assume the whole namespace is derived solely from key.

Suggested change
* Example: apidocSpec => apidoc.spec
* Example:
* orgNamespace = "me.apidoc", key = "apidocSpec" => "me.apidoc.spec"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants