Extract generateNoise into shared RNG-customizable utility - #178
Merged
Conversation
Move the duplicated private generateNoise(count:seed:) from Flux2Pipeline, SD3Pipeline, and StableDiffusionPipeline into a module-level free function in RNG/NoiseGeneration.swift. The new function accepts a RandomSourceType parameter (.numPy, .torch, .nvidia) defaulting to .numPy for backwards compatibility, allowing callers to select the appropriate RNG for their model.
stikves
requested review from
alejandro-isaza,
carinapeng,
kevchengcodes and
tjia1818
August 17, 2026 16:44
kevchengcodes
approved these changes
Aug 17, 2026
tjia1818
reviewed
Aug 17, 2026
tjia1818
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the duplicated private generateNoise(count:seed:) from Flux2Pipeline, SD3Pipeline, and StableDiffusionPipeline into a module-level free function in RNG/NoiseGeneration.swift.
The new function accepts a RandomSourceType parameter (.numPy, .torch, .nvidia) defaulting to .numPy for backwards compatibility, allowing callers to select the appropriate RNG for their model.