Fix segmentation tests after ModelIONameResolver extraction - #181
Merged
Conversation
stikves
force-pushed
the
sukru/fix-segmentation-tests
branch
2 times, most recently
from
August 17, 2026 23:23
7a69f3e to
4b9ec69
Compare
tjia1818
approved these changes
Aug 18, 2026
tjia1818
requested changes
Aug 18, 2026
tjia1818
left a comment
tjia1818
left a comment
Contributor
There was a problem hiding this comment.
pls make sure the commit is verified
findImageInputName and findLogitsOutputName moved to ModelIONameResolver in CoreAIShared — update test references.
stikves
force-pushed
the
sukru/fix-segmentation-tests
branch
from
August 18, 2026 17:05
4b9ec69 to
674483f
Compare
Contributor
Author
done |
tjia1818
approved these changes
Aug 18, 2026
kevchengcodes
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line fix: update test references after #177 moved
findImageInputNameandfindLogitsOutputNamefromCoreAISegmentationEnginetoModelIONameResolverin CoreAIShared.Changes
ImageSegmentationEngineTests.swift: importCoreAIShared, useModelIONameResolver.findImageInputName/findLogitsOutputNameTest plan