Make endpoint types sendable - #80
Open
porchdog wants to merge 4 commits into
Open
Conversation
porchdog
requested review from
agnosticdev,
ekinnear and
tfpauly
as code owners
August 13, 2026 04:17
tfpauly
reviewed
Aug 13, 2026
agnosticdev
reviewed
Aug 13, 2026
tfpauly
approved these changes
Aug 13, 2026
Contributor
|
The way that this pattern (a class-backed-struct) is made I suspect that we want to take that approach here since we are already using the NIO CoW pattern. |
porchdog
force-pushed
the
porchdog/endpoint-type-sendable
branch
from
August 14, 2026 17:05
24a25e1 to
fca6bd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Sendability conformance to
Endpoint.EndpointTypeenum. This was mostly mechanical save forBonjourEndpointandApplicationServiceEndpointwhich needed locking support to protect access to the mutableStorageobject.