Repository navigation
Rewrite uninstall-ace.sh to remove only ACE-owned releases - #1364
Merged
Merged
Conversation
Select HelmReleases by their ace-installer/FeatureSet owner annotation instead of a hardcoded list, uninstall them via Flux in dependency order, unblock releases whose finalizer controllers are already gone, and add --full-prune to also remove KubeDB/KubeStash/OCM objects, AppsCode CRDs and ACE namespaces. Third-party CRDs are never touched. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
Delete ManagedClusters and the ClusterManager while the cluster-manager operator and work-controller are still running, so the hub deployments, webhooks, RBAC and ManifestWork finalizers get cleaned up instead of being orphaned. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
…eases Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites
hack/deploy/uninstall-ace.shso it works on edge clusters running other workloads.meta.helm.sh/release-name=ace-installeror a FeatureSet name) instead of a hardcoded list; unrelated releases are untouched.ace→catalog-manager→ace/gateway→ rest →opscenter-features+ Features → core (cert-manager, license-proxyserver, kube-ui-server, akp-crd-manager) →ace-installer.ace) and dangling ACE APIServices.--full-pruneadditionally deletes ManagedClusters, KubeDB databases (WipeOut), KubeStash backups/repositories/storages, AppsCode CRDs and ACE namespaces. Third-party CRDs (cert-manager, prometheus-operator, gateway-api, envoy, OCM, trickster) are never deleted.kubectl,helm,jq.