Repository navigation
Conversation
schemen
force-pushed
the
add_tls_restore_tip
branch
from
November 4, 2026 14:06
94744fb to
c05c97d
Compare
HappyTetrahedron
approved these changes
Nov 4, 2026
simu
reviewed
Nov 4, 2026
|
|
||
| Apply the extracted and prepared objects to the target cluster. | ||
|
|
||
| TIP: Restore TLS Secrets before restoring Ingress or Gateway resources to prevent unnecessary certificate reissuance. Avoid restoring Certificate objects generated by Ingress or Gateway resources, as their ownerReferences may be outdated. Let cert-manager recreate these Certificates automatically. |
Member
There was a problem hiding this comment.
Please keep it to one sentence per line...
Suggested change
| TIP: Restore TLS Secrets before restoring Ingress or Gateway resources to prevent unnecessary certificate reissuance. Avoid restoring Certificate objects generated by Ingress or Gateway resources, as their ownerReferences may be outdated. Let cert-manager recreate these Certificates automatically. | |
| [TIP] | |
| ==== | |
| Restore TLS secrets before restoring `Certificate`, `Ingress` or `Gateway` resources to prevent unnecessary certificate reissuance. | |
| Avoid restoring Certificate objects generated by `Ingress` or `Gateway` resources, as their owner references may be outdated. | |
| Let cert-manager recreate these certificates automatically. | |
| ==== |
Additionally, consider linking to the cert-manager docs in the actual docs instead of just the PR description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tip stems from the documentation provided by cert-manager: https://cert-manager.io/docs/devops-tips/backup/#avoiding-unnecessary-certificate-reissuance