feat: Flutter SDK update for version 23.1.0#307
Conversation
Greptile SummaryThis PR bumps the Flutter SDK to 23.1.0, adding the Confidence Score: 5/5Safe to merge; only P2 findings remain, no functional bugs introduced. All changes are straightforward SDK updates (version bumps, new enum value, new model field, new accessor method). The only concern is that adding CHANGELOG.md — the missing [BREAKING] annotation for the Log constructor change. Important Files Changed
Reviews (1): Last reviewed commit: "Commit from GitHub Actions (Format and p..." | Re-trigger Greptile |
|
|
||
| * Added `x` OAuth provider to `OAuthProvider` enum | ||
| * Added `userType` field to `Log` model | ||
| * Added `getHeaders()` method to `Client` |
There was a problem hiding this comment.
Missing
[BREAKING] tag for Log constructor change
Adding userType as a required named parameter to the Log constructor is a source-breaking change — any code that constructs Log directly (e.g. in unit tests or test doubles) will fail to compile without updating the call site. The 23.0.0 entry uses [BREAKING] for the $sequence type change, but this addition is unmarked in 23.1.0.
| * Added `getHeaders()` method to `Client` | |
| * [BREAKING] Added required `userType` field to `Log` model |
| Map<String, String> getHeaders() { | ||
| return Map<String, String>.from(_headers!); | ||
| } |
There was a problem hiding this comment.
getHeaders() exposes sensitive authentication headers
The returned map includes all headers set via addHeader, which may contain X-Appwrite-JWT, X-Appwrite-Session, X-Appwrite-Dev-Key, or impersonation tokens. The defensive copy (Map.from(...)) prevents mutation of internal state, which is good, but callers receive plain-text copies of any credentials stored in _headers. A brief doc comment noting that the return value may include sensitive values would help consumers use this API safely.
This PR contains updates to the Flutter SDK for version 23.1.0.