Fix CLI Homebrew checksum matcher in publish workflow template#1446
Merged
ChiragAgg5k merged 1 commit intomasterfrom Apr 14, 2026
Merged
Fix CLI Homebrew checksum matcher in publish workflow template#1446ChiragAgg5k merged 1 commit intomasterfrom
ChiragAgg5k merged 1 commit intomasterfrom
Conversation
Greptile SummaryReplaces the invalid Confidence Score: 5/5
Important Files Changed
Reviews (1): Last reviewed commit: "fix: escape CLI Homebrew checksum artifa..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sync the CLI publish workflow template with the fix already applied in
appwrite/sdk-for-cli.The generated workflow was using a Ruby regex literal with
\Q#{artifact}\Ewhen rewriting Homebrew SHA256 entries. That matcher failed in the release job, so the checksum update aborted even though the release assets and npm publish had already completed.This switches the matcher to
Regexp.escape(artifact), which matches the generated formula content correctly.Test Plan
php example.php cliexamples/cli/.github/workflows/publish.ymlusesRegexp.escape(artifact)appwrite/sdk-for-cliand confirmed the substitutions succeed with this patternRelated