Skip to content

tested#2

Open
Kojfer13 wants to merge 2 commits into
arcmags:mainfrom
Kojfer13:backup
Open

tested#2
Kojfer13 wants to merge 2 commits into
arcmags:mainfrom
Kojfer13:backup

Conversation

@Kojfer13
Copy link
Copy Markdown

@Kojfer13 Kojfer13 commented Jan 9, 2025

Added a backup option

@arcmags
Copy link
Copy Markdown
Owner

arcmags commented Jan 11, 2025

I appreciate the contribution, but I'd like to see some changes before merging.

Firstly, all variables in a shell script should be properly quoted, so something like:

tar -cvf $name $srv

needs to be changed to:

tar -cvf "$name" "$srv"

Also the backup location is hardcoded to a root directory that may or may not exist and may or may not be writable:

bck="/backups"

This probably shouldn't be hardcoded to a root directory. Some checks need to be performed to see if it exists and is writable. A config option should exist in minecraftd.conf to set the backups location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants