tested#2
Open
Kojfer13 wants to merge 2 commits into
Open
Conversation
Owner
|
I appreciate the contribution, but I'd like to see some changes before merging. Firstly, all variables in a shell script should be properly quoted, so something like: needs to be changed to: Also the backup location is hardcoded to a root directory that may or may not exist and may or may not be writable: This probably shouldn't be hardcoded to a root directory. Some checks need to be performed to see if it exists and is writable. A config option should exist in minecraftd.conf to set the backups location. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a backup option