Conversation
| mitigations.addAll( | ||
| node.getSinkAdditionMitigations(mitigation)); | ||
| }catch (Exception e) { | ||
| // TODO: handle exception |
There was a problem hiding this comment.
Please handle this exception.
There was a problem hiding this comment.
Or throw it with a matching method declaration
| StandardOpenOption.APPEND | ||
| ); | ||
|
|
||
| if (!exists) { |
There was a problem hiding this comment.
It would be cleaner to have a dedicated record for these results and serialize lists of these objects rather than 174 lines of string magic. Any reason why you did it this way?
There was a problem hiding this comment.
You already have a runConfic. Couldnt you do a data structure for the reamaining relevant data?
|
|
||
| if (solutions.size() > 10000) { | ||
| if (deactivateSubsumption) | ||
| if (solutions.size() > 100000) { |
There was a problem hiding this comment.
This changes SAT. I would rather not merge this as is.
There was a problem hiding this comment.
You can either revert the file now or before the whole MA gets merged into Main
| @@ -624,6 +625,10 @@ private void applyActions(DataFlowDiagramAndDictionary dfd, List<Term> actions) | |||
| cast.getOutputLabels() | |||
| .add(label); | |||
| } | |||
There was a problem hiding this comment.
Why do you change the mechanic here?
There was a problem hiding this comment.
Is it because your source sink model has a set and the mechanic coulnt apply changes to a set assignment?
| @@ -0,0 +1,301 @@ | |||
| package dev.arcovia.mitigation.sat.tests; | |||
There was a problem hiding this comment.
Is this class a copy for your ilp performance class? seems that way.
2 participants
No description provided.