refactor: Rename inconsistency concepts - MME→TEAM, UME→MEAT#23
Merged
Conversation
Rename Missing Model Elements (MME) to Text Entity Absent from Model (TEAM) and Undocumented Model Elements (UME) to Model Entity Absent from Text (MEAT) to use clearer, more descriptive terminology. This commit includes: - Renamed Java classes for both inconsistency types and their agents - Updated REST API to use new type identifiers - Updated TypeScript/React frontend (traceview-v2) components and data models - Updated documentation and website content - Cleaned up duplicate test files - Added @SuppressWarnings annotations to test methods with null parameters BREAKING CHANGE: REST API inconsistency type identifiers changed from "MissingModelInstance"/"MissingTextForModelElement" to "TextEntityAbsentFromModel"/"ModelEntityAbsentFromText"
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors inconsistency detection terminology from "Missing Model Elements (MME)" and "Undocumented Model Elements (UME)" to more descriptive names: "Text Entity Absent from Model (TEAM)" and "Model Entity Absent from Text (MEAT)". This is a breaking API change that updates type identifiers returned in REST API responses.
Changes:
- Updated Java class imports and type checking logic in
InconsistencyConverter.java - Updated REST API response type identifiers from
MissingModelInstance/MissingTextForModelElementtoTextEntityAbsentFromModel/ModelEntityAbsentFromText - Updated documentation examples in
architecture_decisions.mdto reflect new type names
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/edu/kit/kastel/mcse/ardoco/tlr/rest/api/converter/InconsistencyConverter.java | Updated imports, type string checks, and variable names to use new inconsistency class names; updated copyright year to 2025-2026 |
| architecture_decisions.md | Updated example JSON responses to use new API type identifiers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename Missing Model Elements (MME) to Text Entity Absent from Model (TEAM) and Undocumented Model Elements (UME) to Model Entity Absent from Text (MEAT) to use clearer, more descriptive terminology.
This commit includes:
BREAKING CHANGE: REST API inconsistency type identifiers changed from "MissingModelInstance"/"MissingTextForModelElement" to "TextEntityAbsentFromModel"/"ModelEntityAbsentFromText"