fix(argo-cd): make gateway API backend protocol selection work for server #3585
+41
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann-soubeyrand
requested review from
jmeridth,
mbevc1,
mkilchhofer,
pdrastil,
tico24 and
yu-croco
as code owners
yann-soubeyrand
force-pushed
the
argocd-server-backend-protocol-selection
branch
from
0fbcc89 to
3355943
Compare
yann-soubeyrand
force-pushed
the
argocd-server-backend-protocol-selection
branch
from
3355943 to
0451c32
Compare
…rver When using gateway API (https://gateway-api.sigs.k8s.io/) to configure a Gateway and an HTTPRoute to access Argo CD server, backend protocol selection (https://gateway-api.sigs.k8s.io/guides/backend-protocol/) relies on the appProtocol field of the backend service port (https://gateway-api.sigs.k8s.io/reference/spec/#backendref). Valid values for this field are described in KEP-3726 (https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/3726-standard-application-protocols). Since Argo CD server serves web UI using HTTP 1 and GRPC using HTTP 2, both on the same port, two ports redirecting to the same pod port are needed on the service. Signed-off-by: Yann Soubeyrand <[email protected]>
yann-soubeyrand
force-pushed
the
argocd-server-backend-protocol-selection
branch
from
0451c32 to
12b26b4
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using gateway API (https://gateway-api.sigs.k8s.io/) to configure a Gateway and an HTTPRoute to access Argo CD server, backend protocol selection (https://gateway-api.sigs.k8s.io/guides/backend-protocol/) relies on the appProtocol field of the backend service port (https://gateway-api.sigs.k8s.io/reference/spec/#backendref). Valid values for this field are described in KEP-3726
(https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/3726-standard-application-protocols).
Since Argo CD server serves web UI using HTTP 1 and GRPC using HTTP 2, both on the same port, two ports redirecting to the same pod port are needed on the service.
Checklist: