Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "cucumber-java-test-runner",
"displayName": "Cucumber Test Runner for Java",
"description": "Run and debug Cucumber BDD scenarios from VS Code's native Test Explorer. Integrates with Maven and cucumber-junit-platform-engine.",
"version": "0.1.2",
"version": "0.1.3",
"publisher": "arunkris",
"license": "MIT",
"repository": {
Expand Down
3 changes: 2 additions & 1 deletion src/execution/mavenRunner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ export class MavenRunner implements BuildToolRunner {

// Only run the Cucumber engine — prevents non-Cucumber tests from
// executing and avoids double execution through the Suite engine.
args.push('-Dincludejunit5engines=cucumber');
// User property name: surefire.includeJUnit5Engines (fixed in SUREFIRE-2059).
args.push('-Dsurefire.includeJUnit5Engines=cucumber');

// Pass glue so the Cucumber engine finds step definitions without
// scanning the entire classpath.
Expand Down
6 changes: 3 additions & 3 deletions src/test/unit/mavenRunner.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ describe('MavenRunner', () => {
featureTargets: ['src/test/resources/login.feature:10'],
runnerClass: 'CucumberTest',
});
assert.ok(cmd.args.includes('-Dincludejunit5engines=cucumber'),
assert.ok(cmd.args.includes('-Dsurefire.includeJUnit5Engines=cucumber'),
'Should include engine filter');
assert.ok(!cmd.args.some(a => a.startsWith('-Dtest=!')),
'Should NOT use -Dtest=! exclusion');
Expand All @@ -226,7 +226,7 @@ describe('MavenRunner', () => {
projectRoot: tmpDir,
featureTargets: ['src/test/resources/login.feature:10'],
});
assert.ok(cmd.args.includes('-Dincludejunit5engines=cucumber'),
assert.ok(cmd.args.includes('-Dsurefire.includeJUnit5Engines=cucumber'),
'Should include engine filter even without runnerClass');
assert.ok(!cmd.args.some(a => a.startsWith('-Dtest=')),
'Should not have any -Dtest arg');
Expand Down Expand Up @@ -263,7 +263,7 @@ describe('MavenRunner', () => {
featureTargets: [],
runnerClass: 'com.example.RunCucumber',
});
assert.ok(!cmd.args.includes('-Dincludejunit5engines=cucumber'),
assert.ok(!cmd.args.includes('-Dsurefire.includeJUnit5Engines=cucumber'),
'Should not include engine filter for Run All');
assert.ok(cmd.args.includes('-Dtest=com.example.RunCucumber'),
'Should use -Dtest for Run All');
Expand Down