You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
DarshanCode2005
changed the title
refactor: use top-level await, node imports, and secure zip extraction
refactor: node imports, and secure zip extraction (file: scripts\fetch-asyncapi-example.js)
Jan 14, 2026
@Shurtu-gal sir, @AayushSaini101 sir,
Could you please review the improvements made in fetch-asyncapi-example.js?
There is still one SonarCloud issue remaining that suggests removing the Promise in favor of top-level await. Applying that change would require converting the file (or module) to ESM, which breaks the current CommonJS setup and existing builds. For this reason, I believe this specific issue should be ignored. Apart from this, all SonarCloud other problems in the file have been addressed.
I have included below the link to the related SonarCloud findings for you to refer to. https://sonarcloud.io/project/issues?fileUuids=AZA0tMV-KSpUHBkKhrAA&issueStatuses=OPEN%2CCONFIRMED&id=asyncapi_cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: #1881
Summary
This PR modernizes the example-fetching script and fixes a ZIP extraction security issue. (file: scripts\fetch-asyncapi-example.js)
Changes