Fix project selection after changing Jira sites#1902
Open
GagandeepSingh20 wants to merge 1 commit into
Open
Conversation
|
Hooray! All contributors have signed the CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Is This Change?
Fixes #1896.
This change fixes the selected Jira project disappearing from the project dropdown after switching Jira sites.
The issue was caused by inconsistent project identifiers:
project.id.project.key.project.id.Because the dropdown option value and selected project value did not match, the selected project could not be displayed.
This change standardizes the project option value on
project.idin theUpdatedSelectedSitereducer path.A regression test has also been added to verify that, after changing Jira sites, the selected project ID matches the corresponding project option value.
How Has This Been Tested?
Added a focused React unit test covering the
UpdatedSelectedSitereducer flow.The test verifies that:
project.idas their value.Command used:
Result:
Basic checks:
npm run lintnpm run testAdvanced checks:
Recommendations:
Rovo Dev code review: Rovo Dev couldn't review this pull request
The pull request author does not have access to Rovo Dev.