Fix a race condition in context_destroy#2277
Open
pguyot wants to merge 1 commit intoatomvm:release-0.7from
Open
Fix a race condition in context_destroy#2277pguyot wants to merge 1 commit intoatomvm:release-0.7from
context_destroy#2277pguyot wants to merge 1 commit intoatomvm:release-0.7from
Conversation
Another scheduler may be running `update_timer_list` while the context was being destroyed. Force synchronization by inconditionally calling `scheduler_cancel_timeout` which holds the spinlock and cancel any timeout before the process is removed from the process table. This seems to fix some crashes on macOS under heavy load. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
petermm
approved these changes
Apr 20, 2026
bettio
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another scheduler may be running
update_timer_listwhile the context was being destroyed. Force synchronization by inconditionally callingscheduler_cancel_timeoutwhich holds the spinlock and cancel any timeout before the process is removed from the process table.This seems to fix some crashes on macOS under heavy load.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later