UPSTREAM PR #1321: 🧪 Add tests for binary reading functions#77
Open
UPSTREAM PR #1321: 🧪 Add tests for binary reading functions#77
Conversation
- Refactored `read_u64`, `read_int`, and `read_short` from `model.cpp` to `util.cpp` and `util.h` to make them testable. - Improved the implementation of these functions with explicit types and safer casts. - Added a new test suite in `tests/test_binary_reader.cpp` covering various scenarios and edge cases. - Integrated the tests into the CMake build system. Co-authored-by: torusvektor <117734669+torusvektor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: leejet/stable-diffusion.cpp#1321
read_u64,read_int, andread_shortfrommodel.cpptoutil.cppandutil.hto make them testable.tests/test_binary_reader.cppcovering various scenarios and edge cases.